Skip to content

Conversation

@anhanhnguyen
Copy link
Contributor

Proposed Changes

Hi,

We would like to extend the quorum queue configuration under https://www.rabbitmq.com/docs/quorum-queues#configuration to support the INI-style format, allowing the following settings:

quorum_queue.cluster_size = 3
quorum_queue.commands_soft_limit = 32

This aims to provide a more consistent and simplified configuration experience for users.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@michaelklishin michaelklishin changed the title Add INI-style configuration option for quorum queue configurations Add a rabbitmq.conf setting for two more quorum queue-related keys Apr 14, 2025
@michaelklishin michaelklishin added this to the 4.1.0 milestone Apr 14, 2025
michaelklishin added a commit that referenced this pull request Apr 14, 2025
@michaelklishin michaelklishin merged commit e557ab3 into rabbitmq:main Apr 14, 2025
268 of 271 checks passed
@michaelklishin
Copy link
Collaborator

Merged manually after renaming one of the options.

Backported manually to v4.1.x.

@anhanhnguyen anhanhnguyen deleted the quorum-queue-config branch April 15, 2025 10:45
mkuratczyk pushed a commit that referenced this pull request Apr 16, 2025
michaelklishin added a commit that referenced this pull request Apr 24, 2025
ikavgo pushed a commit that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants