Fix amqp091->amqp10 shovel with complex headers #13798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
application properties. Before this change, trying to shovel
dead-lettered messages from an AMQP 0.9.1 source to AMQP 1.0 destination
would fail with:
```
reason: {badarg,
[{unicode,characters_to_binary,
[[{table,
[{<<"count">>,long,1},
{<<"reason">>,longstr,<<"maxlen">>},
{<<"queue">>,longstr,<<"tmp">>},
{<<"time">>,timestamp,1745575728},
{<<"exchange">>,longstr,<<>>},
{<<"routing-keys">>,array,
[{longstr,<<"tmp">>}]}]}]],
[{file,"unicode.erl"},
{line,1219},
{error_info,#{module => erl_stdlib_errors}}]},
{amqp10_client_types,utf8,1,
[{file,"amqp10_client_types.erl"},{line,99}]},
{amqp10_msg,'-set_application_properties/2-fun-0-',3,
[{file,"amqp10_msg.erl"},{line,385}]},
{maps,fold_1,4,[{file,"maps.erl"},{line,860}]},
{amqp10_msg,set_application_properties,2,
[{file,"amqp10_msg.erl"},{line,384}]},
{maps,fold_1,4,[{file,"maps.erl"},{line,860}]},
{rabbit_amqp10_shovel,forward,4,
[{file,"rabbit_amqp10_shovel.erl"},{line,337}]},
{rabbit_shovel_worker,handle_info,2,
[{file,"rabbit_shovel_worker.erl"},{line,104}]}]}
```
mkuratczyk
force-pushed
the
amqp091-to-amqp10-shovel-bug
branch
from
c4bf535 to
c5271ea
Compare
Collaborator
|
@mkuratczyk @ansd should we backport this to patch releases? It seems to be a safe change and a genuine bug fix to me. |
michaelklishin
approved these changes
Apr 25, 2025
Contributor
I think it is fine to backport this yes. |
kjnilsson
approved these changes
Apr 25, 2025
Contributor
kjnilsson
left a comment
kjnilsson
left a comment
There was a problem hiding this comment.
This change is fine for now until we can make use of the proper conversions in mc
ansd
approved these changes
Apr 25, 2025
michaelklishin
added a commit
that referenced
this pull request
Apr 25, 2025
Fix amqp091->amqp10 shovel with complex headers (backport #13798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some AMQP 0.9.1 headers, in particular x-death headers, cannot be set as application properties. Before this change, trying to shovel dead-lettered messages from an AMQP 0.9.1 source to AMQP 1.0 destination would fail with:
Fixes #13797