Shovel test flakes and logging fixes (backport #13820) #13821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking that not a single process has a message in the mailbox is prone to flakes. (cherry picked from commit 0ec41c6)
rabbit_channel may use amqp_channel as the writer. When terminating, rabbit_channel sends a `flush` message to its writer. If amqp_channel is in use, that led to a `function_clause` crash. (cherry picked from commit 0ce6ad0)
(cherry picked from commit 0f36610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function_clausewhen rabbit_channel sentflushmessage to its writerdirectconnection logged a crash error just because the amqp_channel exited0messages in the mailbox for all processes, but it's a live runtime, something could be thereThis is an automatic backport of pull request Shovel test flakes and logging fixes #13820 done by Mergify.