Skip to content

Conversation

@dcorbacho
Copy link
Contributor

No description provided.

@michaelklishin michaelklishin changed the title Mgmt UI: Add super streams page Management UI: new page and elements for superstreams (partitioned streams) Apr 30, 2025
Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, when you add a superstream, the form clears and there are no visible changes. The actual partitions will only be visible on the Queues and Streams page.

Should we redirect to the Queues and Streams page in the UI code?

And yes, we should validate virtual host for existence similarly
to what rabbit_mgmt_wm_queues does:

resource_exists(ReqData, {Mode, Context}) ->
    %% just checking that the vhost requested exists
    {case rabbit_mgmt_util:all_or_one_vhost(ReqData, fun (_) -> [] end) of
         vhost_not_found -> false;
         _               -> true
     end, ReqData, {Mode, Context}}.

@dcorbacho dcorbacho force-pushed the super-streams-ui branch from 3309e78 to ef09b19 Compare May 4, 2025 17:54
@dcorbacho
Copy link
Contributor Author

@michaelklishin changes done

@dcorbacho dcorbacho requested a review from michaelklishin May 5, 2025 06:43
@michaelklishin michaelklishin added this to the 4.2.0 milestone May 5, 2025
@michaelklishin michaelklishin merged commit 451850f into main May 5, 2025
3 checks passed
@michaelklishin michaelklishin deleted the super-streams-ui branch May 5, 2025 16:34
michaelklishin added a commit that referenced this pull request May 5, 2025
Management UI: new page and elements for superstreams (partitioned streams) (backport #13836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants