Add a proptest checking ra_indexes indices
#13920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly the same as the `messages_total` property test but checks that the Raft indexes in `ra_indexes` are the set of the indexes checked out by all consumers union any indexes in the `returns` queue. This is the intended state of `ra_indexes` and failing this condition could cause bugs that would prevent snapshotting.
michaelklishin
added a commit
that referenced
this pull request
May 21, 2025
Add a proptest checking `ra_indexes` indices (backport #13920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the same as the
messages_totalproperty test but checks that the Raft indexes inra_indexesare the set of the indexes checked out by all consumers union any indexes in thereturnsqueue. This is the intended state ofra_indexesand failing this condition could cause bugs that would prevent snapshotting.(Discussed with @kjnilsson)