Always emit consumer_deleted event when stream consumer goes away (backport #13970) #13976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only when it is removed explicitly by the client. This is necessary to make sure the consumer record is removed from the management ETS tables (consumer_stats) and to avoid ghost consumers. For other protocols like AMQP 091, the consumer_status ETS table is cleaned up when a channel goes down, but there is no channel concept in the stream protocol. This is not consistent with other protocols or queue implementations (which emits the event only on explicit consumer cancellation) but is necessary to clean up stats correctly. References #13092 (cherry picked from commit 52c89ab)
Collaborator
|
@acogoluegnes the failure in |
Contributor
|
@michaelklishin The test passes locally for me, it seems to be OK now on CI, it was a glitch I guess. Can we merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only when it is removed explicitly by the client. This is necessary to make sure the consumer record is removed from the management ETS tables (consumer_stats) and to avoid ghost consumers.
For other protocols like AMQP 091, the consumer_status ETS table is cleaned up when a channel goes down, but there is no channel concept in the stream protocol.
This is not consistent with other protocols or queue implementations (which emits the event only on explicit consumer cancellation) but is necessary to clean up stats correctly.
References #13092
This is an automatic backport of pull request #13970 done by Mergify.