Make queue commands generic - i.e. make them work with any queue type #14119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikavgo
force-pushed
the
ik-generalize-queue-commands
branch
from
187fa20 to
1940384
Compare
Contributor
Author
|
CLI formatter tests are red after this commit - 00528cb. I pinged Luke. |
ikavgo
force-pushed
the
ik-generalize-queue-commands
branch
from
1940384 to
c0e7df7
Compare
Contributor
Author
|
@michaelklishin ping |
Contributor
Author
|
Closing, this will go elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing Queues as Plugins Saga with generalizing queues commands.
I also tried to define types for #resource record fields, but unsuccessfully - the r1/2/3 helper types we have confuse dialyzer.