Show current state of deprecated features (backport #14227) #14229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e7c2dc5)
bas0N
added a commit
to bas0N/rabbitmq-server
that referenced
this pull request
Dec 1, 2025
The /api/deprecated-features/used endpoint was returning an empty state field in the JSON response. This was a regression introduced in rabbitmq#14229, which added the state field to show whether deprecated features are permitted or denied. The issue was that rabbit_depr_ff_extra:cli_info0/1 always tried to extract the state field with a default empty string, even when rabbit_deprecated_features:list(used) doesn't include a state field (unlike list(all) which does). This commit fixes the issue by only including the state field when it exists in the feature properties, using maps:find/2 and maps:merge/2 to conditionally add it. The fix ensures that: - /api/deprecated-features returns state field with valid values - /api/deprecated-features/used omits the state field entirely Tests are updated to verify this behavior. GitHub issue: rabbitmq#14340
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
The /api/deprecated-features/used endpoint was returning an empty state field in the JSON response. This was a regression introduced in #14229, which added the state field to show whether deprecated features are permitted or denied. The issue was that rabbit_depr_ff_extra:cli_info0/1 always tried to extract the state field with a default empty string, even when rabbit_deprecated_features:list(used) doesn't include a state field (unlike list(all) which does). This commit fixes the issue by only including the state field when it exists in the feature properties, using maps:find/2 and maps:merge/2 to conditionally add it. The fix ensures that: - /api/deprecated-features returns state field with valid values - /api/deprecated-features/used omits the state field entirely Tests are updated to verify this behavior. GitHub issue: #14340 (cherry picked from commit d2a3a60)
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
The /api/deprecated-features/used endpoint was returning an empty state field in the JSON response. This was a regression introduced in #14229, which added the state field to show whether deprecated features are permitted or denied. The issue was that rabbit_depr_ff_extra:cli_info0/1 always tried to extract the state field with a default empty string, even when rabbit_deprecated_features:list(used) doesn't include a state field (unlike list(all) which does). This commit fixes the issue by only including the state field when it exists in the feature properties, using maps:find/2 and maps:merge/2 to conditionally add it. The fix ensures that: - /api/deprecated-features returns state field with valid values - /api/deprecated-features/used omits the state field entirely Tests are updated to verify this behavior. GitHub issue: #14340 (cherry picked from commit d2a3a60) (cherry picked from commit 9c4cbf2)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing deprecated features, apart from the deprecation phase, show the current state (whether the configuration permits usage).
New column in the CLI outout:
New column in the Management UI:
This is an automatic backport of pull request #14227 done by [Mergify](https://mergify.com).