Handle exceptions in rabbit_ct_helpers:await_condition_with_retries/2 to continue waiting

[Ayanda-D]

Proposed Changes

Hi folks, we want this helper to continue waiting despite some test condition throwing exceptions. Needed for some custom plugins. Also, this allows removal of a lot of unnecessary custom wait functions in unit tests.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)
• Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally with my changes
• If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
• If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

[michaelklishin]

@Ayanda-D this has a serious negative effect on the cases where a test should fail quickly due to an exception. So after thinking about those cases some more, I have reverted this PR. This can have serious negative consequences on developer productivity in some cases where the wait time must be high (say, 30s and not 5s) but you need the tests to fail quickly in case of any exception.

I'd accept a PR with a different version of await_condition_with_retries/2 that your plugins can use. I don't have a better name than await_condition_with_retries_ignoring_exceptions/2.

[Ayanda-D]

@michaelklishin ok noted, I've opened #14270