Skip to content

Bump actions/download-artifact from 4 to 5 #14337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump actions/download-artifact from 4 to 5 #14337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f77c74
Bump actions/download-artifact from 4 to 5
dependabot[bot] Aug 6, 2025
5e9287e
actions/upload-artifact version must match actions/download-artifact
michaelklishin Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/oci-make-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
make package-generic-unix PROJECT_VERSION=${{ matrix.project_version || steps.tag.outputs.project_version }}+${{ github.sha }}

- name: Upload package-generic-unix
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: package-generic-unix-otp${{ matrix.otp_version }}-${{ matrix.branch }}
path: PACKAGES/rabbitmq-server-*.tar.xz
Expand All @@ -81,7 +81,7 @@ jobs:
ref: ${{ matrix.branch }}

- name: Download package-generic-unix
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
name: package-generic-unix-otp${{ matrix.otp_version }}-${{ matrix.branch }}
path: PACKAGES
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/oci-make.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
make package-generic-unix PROJECT_VERSION=${{ env.VERSION }}
- name: Upload package-generic-unix
if: steps.authorized.outputs.authorized == 'true'
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: package-generic-unix-otp${{ matrix.otp_version }}
path: PACKAGES/rabbitmq-server-*.tar.xz
Expand All @@ -84,7 +84,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Download package-generic-unix
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
name: package-generic-unix-otp${{ matrix.otp_version }}
path: PACKAGES
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/peer-discovery-aws.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
make -C deps/rabbitmq_peer_discovery_aws ct-integration
- name: UPLOAD TEST LOGS
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: CT logs
path: "logs/"
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/test-authnz.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,22 +73,22 @@ jobs:

- name: Run Suites
id: tests
run: |
run: |
export IMAGE_TAG=$(find PACKAGES/rabbitmq-server-generic-unix-*.tar.xz | awk -F 'PACKAGES/rabbitmq-server-generic-unix-|.tar.xz' '{print $2}')
export CONF_DIR_PREFIX="$(mktemp -d)"
export CONF_DIR_PREFIX="$(mktemp -d)"
export RABBITMQ_DOCKER_IMAGE=pivotalrabbitmq/rabbitmq:$IMAGE_TAG
echo "Running selenium tests with "
echo " - CONF_DIR_PREFIX: ${CONF_DIR_PREFIX}"
echo " - IMAGE_TAG: ${IMAGE_TAG}"
echo " - RABBITMQ_DOCKER_IMAGE: ${RABBITMQ_DOCKER_IMAGE}"
echo "SELENIUM_ARTIFACTS=${CONF_DIR_PREFIX}" >> $GITHUB_ENV
${SELENIUM_DIR}/run-suites.sh full-suite-authnz-messaging
echo " - RABBITMQ_DOCKER_IMAGE: ${RABBITMQ_DOCKER_IMAGE}"
echo "SELENIUM_ARTIFACTS=${CONF_DIR_PREFIX}" >> $GITHUB_ENV
${SELENIUM_DIR}/run-suites.sh full-suite-authnz-messaging

- name: Upload Test Artifacts
if: ${{ failure() && steps.tests.outcome == 'failure' }}
uses: actions/upload-artifact@v4.3.2
uses: actions/upload-artifact@v5.3.2
with:
name: test-artifacts-${{ matrix.browser }}-${{ matrix.erlang_version }}
name: test-artifacts-${{ matrix.browser }}-${{ matrix.erlang_version }}
path: ${{ env.SELENIUM_ARTIFACTS }}/*

summary-selenium:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-make-target.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:

- name: UPLOAD TEST LOGS
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: CT logs (${{ inputs.plugin }} ${{ inputs.make_target }} OTP-${{ inputs.erlang_version }} ${{ inputs.metadata_store }}${{ inputs.mixed_clusters && ' mixed' || '' }})
path: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-management-ui-for-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,18 @@ jobs:
id: tests
run: |
export IMAGE_TAG=$(find PACKAGES/rabbitmq-server-generic-unix-*.tar.xz | awk -F 'PACKAGES/rabbitmq-server-generic-unix-|.tar.xz' '{print $2}')
export CONF_DIR_PREFIX="$(mktemp -d)"
export CONF_DIR_PREFIX="$(mktemp -d)"
export RABBITMQ_DOCKER_IMAGE=pivotalrabbitmq/rabbitmq:$IMAGE_TAG
echo "Running selenium tests with "
echo " - CONF_DIR_PREFIX: ${CONF_DIR_PREFIX}"
echo " - IMAGE_TAG: ${IMAGE_TAG}"
echo " - RABBITMQ_DOCKER_IMAGE: ${RABBITMQ_DOCKER_IMAGE}"
echo " - RABBITMQ_DOCKER_IMAGE: ${RABBITMQ_DOCKER_IMAGE}"
echo "SELENIUM_ARTIFACTS=${CONF_DIR_PREFIX}" >> $GITHUB_ENV
${SELENIUM_DIR}/run-suites.sh short-suite-management-ui

- name: Upload Test Artifacts
if: ${{ failure() && steps.tests.outcome == 'failure' }}
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: test-artifacts-${{ matrix.browser }}-${{ matrix.erlang_version }}
path: ${{ env.SELENIUM_ARTIFACTS }}/*
8 changes: 4 additions & 4 deletions .github/workflows/test-management-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ jobs:
echo "Running selenium tests with "
echo " - CONF_DIR_PREFIX: ${CONF_DIR_PREFIX}"
echo " - IMAGE_TAG: ${IMAGE_TAG}"
echo " - RABBITMQ_DOCKER_IMAGE: ${RABBITMQ_DOCKER_IMAGE}"
echo " - RABBITMQ_DOCKER_IMAGE: ${RABBITMQ_DOCKER_IMAGE}"
echo "SELENIUM_ARTIFACTS=${CONF_DIR_PREFIX}" >> $GITHUB_ENV
${SELENIUM_DIR}/run-suites.sh full-suite-management-ui
${SELENIUM_DIR}/run-suites.sh full-suite-management-ui

- name: Upload Test Artifacts
if: ${{ failure() && steps.tests.outcome == 'failure' }}
uses: actions/upload-artifact@v4.3.2
uses: actions/upload-artifact@v5.3.2
with:
name: test-artifacts-${{ matrix.browser }}-${{ matrix.erlang_version }}
path: ${{ env.SELENIUM_ARTIFACTS }}/*
Loading