Move rabbit_auth* from rabbit_common to rabbit
#14356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] These modules are not used by amqp_client. Therefore, they shouldn't be in rabbit_common.
Collaborator
|
@Mergifyio backport |
❌ No backport have been created
GitHub error: |
Collaborator
Author
|
It’s a breaking change at the amqp_client API level, it can’t be backported. |
Collaborator
|
@dumbbell yes but if those modules are not actually used by the AMQP 0-9-1 Erlang client, it's in our best interest to reduce the delta between the branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
These modules are not used by
amqp_client. Therefore, they shouldn't be inrabbit_common.