Ensure that tar sets file modified time correctly
#14442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, when the source dist archive is built, the file modified times can be in the future. By adding the `--touch` argument, all files have their modified time set to the extraction time. This prevents the "infinite loop make" behavior described in rabbitmq#14440 These changes also update the arguments passed to `tar` to use full arguments that are easier to understand, as well as removes the need for the `xzcat` command, as all build enviroments should have `xz` support built into GNU `tar`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, when the source dist archive is built, the file modified times can be in the future. By adding the
--touchargument, all files have their modified time set to the extraction time. This prevents the "infinite loop make" behavior described in #14440These changes also update the arguments passed to
tarto use full arguments that are easier to understand, as well as removes the need for thexzcatcommand, as all build enviroments should havexzsupport built into GNUtar.Related to: rabbitmq/rabbitmq-packaging#58
Part of the fix for: #14440