Local shovels: exclude tests in mixed-versions with 3.13.x #14482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suites need to be excluded at group level, so the end_per_suite is always executed and the cluster stopped. Otherwise, clusters remain running in CI and the following suites find the TCP ports busy.
mkuratczyk
approved these changes
Sep 2, 2025
Contributor
mkuratczyk
left a comment
mkuratczyk
left a comment
There was a problem hiding this comment.
Mixed version tests between this branch and 3.13 are green, which was the goal:
https://github.com/rabbitmq/rabbitmq-server/actions/runs/17396967509/job/49380922247
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
The test suites need to be excluded at group level, so the end_per_suite is always executed and the cluster stopped. Otherwise, clusters remain running in CI and the following suites find the TCP ports busy. (cherry picked from commit 7f1febe)
michaelklishin
added a commit
that referenced
this pull request
Sep 2, 2025
Local shovels: exclude tests in mixed-versions with 3.13.x (backport #14482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suites need to be excluded at group level, so the end_per_suite is always executed and the cluster stopped. Otherwise, clusters remain running in CI and the following suites find the TCP ports busy.