WIP DO NOT MERGE: replace httpc with gun fmt #14492
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he old one but curretly they will live side by side
There is `gun:stream_ref()` but not a custom type for the conn pid, so dialyzer was unhappy.
Binaries are unnecessarily restrictive since gun allows sending iodata bodies. This would be useful for larger requests where we want to combine multiple lists or binaries without paying the cost of concatenating them. Note that `crypto:hash/2` accepts an `iodata()` arg. Also this commit avoids double-SHA256-hashing the request body in `rabbitmq_aws_sign`. The `request_hash/5` function performed a second `sha256/1` of the body to get the payload hash but this value already exists at the top of `headers/1`.
In some cases we can compute this incrementally with the streaming hash
utilities from crypto:
> Hash0 = crypto:hash_init(sha256),
> Hash1 = crypto:hash_update(Hash0, Data0),
%% ...
> HashN = crypto:hash_update(HashN1, DataN),
> Hash = crypto:hash_final(HashN).
Especially for large bodies this lets us skip a lot of double work.
Currently this is only added to the direct_request API, with the idea
that the other method that blocks the server is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Switch out the use of httpc in rabbitmq_aws in favor of
gun.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.