rabbit_fifo: Expose each smallest raft index in overview/1 (backport #14493) (backport #14502)
#14503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This is meant to be used as a debugging tool via an eval command. It can be hard to tell from the outside why a QQ is not snapshotting. Looking at the `overview/1` is a nice debugging tool. The `smallest_raft_index` key (and other keys like the `release_cursors`) points out why a snapshot isn't being taken. The `smallest_raft_index` is the minimum of three criteria though: * oldest ready message * oldest checked out message * oldest message in the dlx state This change adds all of those indexes so that it is clear which criteria is keeping the `smallest_raft_index` down. (cherry picked from commit 7f36b01) (cherry picked from commit c59e4ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be used as a debugging tool via an eval command. It can be hard to tell from the outside why a QQ is not snapshotting. Looking at the
overview/1is a nice debugging tool. Thesmallest_raft_indexkey (and other info like therelease_cursors) point out why a snapshot isn't being taken. Thesmallest_raft_indexis the minimum of three criteria though:This change adds all of those indexes so that it is clear which criteria is keeping the
smallest_raft_indexdown.This is an automatic backport of pull request #14493 done by Mergify.
This is an automatic backport of pull request #14502 done by Mergify.