Optimise Khepri for concurrent reads (backport #14530) #14532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes read operations for the following Khepri projections much cheaper: * rabbit_khepri_queue * rabbit_khepri_exchange * rabbit_khepri_index_route * rabbit_khepri_topic_trie Entries in these ETS tables are read for every message entering RabbitMQ. Some messages entering RabbitMQ will cause even multiple reads from these ETS tables, e.g. multiple reads from `rabbit_khepri_queue` if a message is routed to more than one queue or multiple reads from `rabbit_khepri_index_route` if a message has multiple routing keys. On a busy RabbitMQ node, these tables are read concurrently (on multiple physical processors) hundreds of thousands of times per second. (cherry picked from commit d29cac3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes read operations for the following Khepri projections much cheaper:
Entries in these ETS tables are read for every message entering RabbitMQ. Some messages entering RabbitMQ will cause even multiple reads from these ETS tables, e.g. multiple reads from
rabbit_khepri_queueif a message is routed to more than one queue or multiple reads fromrabbit_khepri_index_routeif a message has multiple routing keys.On a busy RabbitMQ node, these tables are read concurrently (on multiple physical processors) hundreds of thousands of times per second.
This is an automatic backport of pull request #14530 done by Mergify.