Skip to content

Conversation

@Zerpet
Copy link
Member

@Zerpet Zerpet commented Sep 22, 2025

Proposed Changes

Follow up to #14449. The trigger is still wrong. I tested locally with act and now it's behaving as expected:
external users without access to secrets do not trigger OCI builds.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@Zerpet Zerpet changed the title Follow up #14449: fix OCI trigger DO NOT MERGE: Follow up #14449: fix OCI trigger Sep 22, 2025
@Zerpet Zerpet marked this pull request as draft September 22, 2025 14:05
@Zerpet Zerpet changed the title DO NOT MERGE: Follow up #14449: fix OCI trigger Follow up #14449: fix OCI trigger Sep 22, 2025
@Zerpet Zerpet marked this pull request as ready for review September 22, 2025 15:50
@michaelklishin michaelklishin added this to the 4.3.0 milestone Sep 22, 2025
@michaelklishin michaelklishin merged commit 2e9d6ee into main Sep 22, 2025
566 of 567 checks passed
@michaelklishin michaelklishin deleted the fix-ci-oci-in-pr branch September 22, 2025 18:29
@michaelklishin
Copy link
Collaborator

@Mergifyio backport v4.2.x

@mergify
Copy link

mergify bot commented Sep 22, 2025

backport v4.2.x

❌ No backport have been created

  • Backport to branch v4.2.x failed

GitHub error: Branch not found

michaelklishin pushed a commit that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants