Add NON_DETERMINISTIC make variable (backport #14577)
#14615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to: * #3442 * 93db480 * #13899 * #14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `NON_DETERMINISTIC` which will be used like this: ``` make NON_DETERMINISTIC=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands. (cherry picked from commit 2eb8ce5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to:
YRL_ERLC_OPTSinstead ofERL_COMPILER_OPTIONS#14326Simply changing
+=to?=doesn't work as there are other important statements added toRMQ_ERLC_OPTSthat can't be left out whenmake RMQ_ERLC_OPTS=''is run. This only became apparent when a completely cleaned-out checkout ofrabbitmq/rabbitmq-serverwas attempted to be built with that command.This adds
NON_DETERMINISTICwhich will be used like this:...and
+deterministicwon't be passed toerlcor other commands.This is an automatic backport of pull request #14577 done by Mergify.