Remove all usage of cacerts from configuration schemas (backport #14655)
#14670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in discussion #14426, the way that `cacerts` is handled by cuttlefish schemas simply will not work if set. If `cacerts` were set to a string value containing one X509 certificate, it would eventually result in a crash because the `cacerts` ssl option must be of [this type](https://www.erlang.org/doc/apps/ssl/ssl.html#t:client_option_cert/0): ``` {cacerts, CACerts :: [public_key:der_encoded()] | [public_key:combined_cert()]} ``` Neither of those are strings, of course. This PR removes all use of `cacerts` in cuttlefish schemas. In addition, it filters out `cacerts` and `certs_keys` from being JSON-encoded by an HTTP API call to `/api/overview`. It _is_ technically possible to set `cacerts` via `advanced.config`, so, if set, it would crash this API call, as would `certs_keys`. (cherry picked from commit ce86fb9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in discussion #14426, the way that
cacertsis handled by cuttlefish schemas simply will not work if set.If
cacertswere set to a string value containing one X509 certificate, it would eventually result in a crash because thecacertsssl option must be of this type:Neither of those are strings, of course. The certs would have to be decoded via
public_key:pem_decode/1then the resulting term matched to get the actual DER-encoded data.This PR removes all use of
cacertsin cuttlefish schemas. In addition, it filters outcacertsandcerts_keysfrom being JSON-encoded by an HTTP API call to/api/overview. It is technically possible to setcacertsviaadvanced.config, so, if set, it would crash this API call, as wouldcerts_keys.This is an automatic backport of pull request #14655 done by Mergify.