rabbit_networking: Support systems with distinct listeners for IPv4 and IPv6 #14741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
support-distinct-ipv4-and-ipv6-listeners
branch
2 times, most recently
from
23bd799 to
2d6df3f
Compare
[Why]
Some systems use explicit distinct listeners for IPv4 and IPv6 (for
instance, FreeBSD). Other system will listen to IPv4 implicitly when
listening on IPv6 (for instance, Linux).
RabbitMQ works on both systems already, but `ranch_ref/1` was trying to
guess the IP address of a given listener based on its TCP port. Of
course, for two distinct listeners using the same TCP port, the result
was always the same IP address.
[How]
The #listener{} record already contains the IP address. Let's just use
it, instead of guessing.
…nd IPv6 [Why] If the system uses distinct listeners for IPv4 and IPv6, the functions listing or stopping listeners would crash because they assumed that the system would listen implicitly to IPv4 when starting an IPv6 listener. This is a common Linuxism. [How] The code now understands that a given protocol can have several associated listeners. The name and return value of several exported functions changed to reflect that they work on several elements or return a list of elements. Therefore it is a breaking change for plugins relying on these functions.
dumbbell
force-pushed
the
support-distinct-ipv4-and-ipv6-listeners
branch
from
2d6df3f to
578c3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If the system uses distinct listeners for IPv4 and IPv6, the functions listing or stopping listeners would crash because they assumed that the system would listen implicitly to IPv4 when starting an IPv6 listener. This is a common Linuxism.
How
The code now understands that a given protocol can have several associated listeners.
The name and return value of several exported functions changed to reflect that they work on several elements or return a list of elements. Therefore it is a breaking change for plugins relying on these functions.