Yet another JSON CLI formatter fix #14773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Oct 22, 2025
The bug addressed by this PR was found while running the following command: ``` rabbitmqctl environment --formatter=json ``` ...after configuring the `rabbit` application to use `cacerts` with a list of binaries as the value, rather than `cacertfile`. This PR also fixes the formatting of the `tcp_listeners` and `ssl_listeners` output, because `[5672]` is a valid list of unicode codepoints that `unicode:characters_to_binary` will happily convert it, resulting in `"tcp_listeners": "ᘨ"` in the output. I also ensured that the fixes in rabbitmq#14511 and rabbitmq#14398 still work as intended.
lukebakken
force-pushed
the
lukebakken/rabbitmq-server-14511-followup
branch
from
38334e7 to
4072326
Compare
the-mikedavis
approved these changes
Oct 22, 2025
michaelklishin
added a commit
that referenced
this pull request
Oct 23, 2025
Yet another JSON CLI formatter fix (backport #14773)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug addressed by this PR was found while running the following command:
...after configuring the
rabbitapplication to usecacertswith a list of binaries as the value, rather thancacertfile.This PR also fixes the formatting of the
tcp_listenersandssl_listenersoutput, because[5672]is a valid list of unicode codepoints thatunicode:characters_to_binarywill happily convert it, resulting in"tcp_listeners": "ᘨ"in the output.I also ensured that the fixes in #14511 and #14398 still work as intended.