Fix shellcheck warnings in selenium component scripts (backport #14860) #14869
+13
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes the most critical shellcheck issues in the selenium test suite's component scripts (
bin/components/*) without adding excessive quoting that changes the existing coding style.Changes made:
#!/usr/bin/env bash) to 3 files that were missing them`command`) with modern$()syntax in 2 filesSCRIPTvariable in rabbitmq componentWhat was NOT changed:
These minimal changes improve script portability (shebangs) and maintainability (modern syntax) while respecting the project's existing coding conventions.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
This is a minimal, conservative approach that addresses only the most important shellcheck findings:
The remaining shellcheck warnings (SC2086 about unquoted variables) are informational and don't represent actual bugs in this codebase. Adding quotes everywhere would be a larger stylistic change that goes beyond fixing actual issues.
This is an automatic backport of pull request #14860 done by Mergify.