Build system: fix rabbit_common, amqp_client, amqp10_client publishing to hex.pm #14915
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEX_TARBALL_FILES included ../../rabbitmq-components.mk which
modern `rebar3 compile` considers to be unsafe and fails on
(quite reasonably).
FTR, the error looks like this:
````
===> Fetching rebar_alias v0.2.0
===> Analyzing applications...
===> Compiling rebar_alias
===> Verifying dependencies...
===> Fetching amqp_client v4.1.5
escript: exception error: no function clause matching
rebar_fetch:format_error({error,
{hex_tarball,
{inner_tarball,
{"../../rabbitmq-components.mk",
unsafe_path}}}}) (/home/runner/work/rebar3/rebar3/apps/rebar/src/rebar_fetch.erl, line 99)
in function rebar3:handle_error/2 (/home/runner/work/rebar3/rebar3/apps/rebar/src/rebar3.erl, line 383)
in call from escript:run/2 (escript.erl, line 904)
in call from escript:start/1 (escript.erl, line 418)
in call from init:start_it/1
in call from init:start_em/1
in call from init:do_boot/3
```
Excluding this relative path addresses the issue.
rabbit_common/Makefile arguably does not need to
add any .mk files to the tarball but let's
deal with that in a separate change.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the rabbitmq-components.mk file from the Hex.pm tarball configuration across multiple RabbitMQ dependency packages.
- Excludes
../../rabbitmq-components.mkfromHEX_TARBALL_FILESin four Makefiles - Ensures only package-specific files (like
git-revisions.txtand mk files) are included in Hex.pm tarballs - The build infrastructure file from the parent directory is still included for build purposes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deps/rabbit_common/Makefile | Removes ../../rabbitmq-components.mk from HEX_TARBALL_FILES, retaining only git-revisions.txt and mk/ directory files |
| deps/amqp_client/Makefile | Removes ../../rabbitmq-components.mk from HEX_TARBALL_FILES, leaving only git-revisions.txt |
| deps/amqp10_common/Makefile | Removes ../../rabbitmq-components.mk from HEX_TARBALL_FILES, leaving only git-revisions.txt |
| deps/amqp10_client/Makefile | Removes ../../rabbitmq-components.mk from HEX_TARBALL_FILES, leaving only git-revisions.txt |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEX_TARBALL_FILESincluded ../../rabbitmq-components.mk which modernrebar3 compileconsiders to be unsafe and fails on (quite reasonably).FTR, the error looks like this:
Excluding this relative path addresses the issue.
rabbit_common/Makefile arguably does not need to
add any .mk files to the tarball but let's
deal with that in a separate change.