Fix quorum queue drop-head dead letter order
#14926
Open
+99
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, quorum queue at-most-once dead lettering for the overflow behaviour `drop-head` was dead lettering in the wrong order.
This commit at-most-once dead letters a huge number of quorum queue messages due to overflow behaviour `drop-head` more efficiently by avoiding repeatedly creating huge lists. A huge number of messages gets dropped if for example: * when the `max-length(-bytes)' is changed via a policy update, or * a very large message was just enqueued causing many small messages being dead lettered due to `max-length-bytes` being exceeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, quorum queue at-most-once dead lettering for the overflow behaviour
drop-headwas dead lettering in the wrong order.