Fix quorum queues rejecting messages during deletion#15365
Open
luos wants to merge 1 commit intorabbitmq:mainfrom
Open
Fix quorum queues rejecting messages during deletion#15365luos wants to merge 1 commit intorabbitmq:mainfrom
luos wants to merge 1 commit intorabbitmq:mainfrom
Conversation
- implement a method to clear bindings before a queue is deleted - leave the "after delete" procedure to make sure to clean up after deletion in case new bindings were created - clear the bindings before the ra:delete_cluster call - usage of default exchange may result in rejections Fixes: rabbitmq#15334
Collaborator
|
As seen numerous times before, we are "fixing" RabbitMQ while what needs fixing is a system design that depends on messages being accepted by a queue that's being concurrently deleted. Deleting bindings before the queue is deleted doesn't make any more sense than deleting the queue first. The fact that it happens to "fix" a system that depends on a very subtle, inherently timing-sensitive behavior that differs between CQs and QQs doesn't justify the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a proposal for the fix of #15334 as discussed.
Let me know what you think.
Proposed Changes
Fixes: #15334
Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
A pull request that doesn't explain why the change was made has a much lower chance of being accepted.
Types of Changes
Checklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocument