CLI: make node_health_check a no-op #4311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
reviewed
Mar 21, 2022
Collaborator
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
How about exiting with status 64 EX_USAGE? That would force people to take notice.
Collaborator
Author
|
I intentionally tried to not break anything. But now that it was suggested for 4.0, I guess we can do that. |
Collaborator
Author
|
I have forgotten about this PR and submitted #9982 for 3.13, haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This legacy health check has been deprecated since 2019 with a group of alternatives available.
Closes #3892, supersedes (rebases) #3893.