Update ra_metrics family for Ra counters #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuratczyk
force-pushed
the
ra_metrics_update
branch
from
67a2fbf to
ef929ba
Compare
Deploying rabbitmq-website with
|
| Latest commit: |
ef929ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a9c6e0d.rabbitmq-website.pages.dev |
| Branch Preview URL: | https://ra-metrics-update.rabbitmq-website.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR rabbitmq/rabbitmq-server#13895 switches from exposing
ra_metricsETS table values as Prometheus metrics, to exposing Ra counters from seshat. There's many more metrics available with this change.A few metrics are the same but have a slightly different name. Since the old name was incorrect, we don't maintain compatibility but use this opportunity to fix the name:
These metrics lost the
_logpart, since they are not log related:rabbitmq_detailed_raft_term_total is now rabbitmq_detailed_raft_term. It was a bug that led to adding the
_totalsuffix.