Skip to content

fix: Improve BMC login logic #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevekeay merged 1 commit into from
Jan 13, 2026
Merged

fix: Improve BMC login logic #1596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions python/understack-workflows/understack_workflows/bmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,26 @@ def session_request(
)
if r.text:
token = r.headers["X-Auth-Token"]
if "Location" in r.headers:
location = r.headers["Location"].split(self.ip_address)[1]
data = r.json()
Copy link
Contributor

@abhimanyu003 abhimanyu003 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if JSON parsing fails?
Shouldn’t we use a try - catch block here?

Copy link
Contributor Author

@stevekeay stevekeay Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the BMC response is invalid JSON then an Exception will be raised, causing the workflow to fail. While the resulting error won't be especially user-friendly, I think the behaviour is broadly correct. If we are looking to move the needle on "user friendly" for an argo workflow, this is probably not the low-hanging fruit :)


if not token:
raise RedfishRequestError("No token from BMC: %s", r.text)

if "@odata.id" in data:
location = data["@odata.id"]
elif "Location" in r.headers:
location_header = r.headers["Location"]
_parts = location_header.split(self.ip_address)
if len(_parts) < 2:
raise RedfishRequestError(
"Can't parse Location Header %s HTTP %s: %s",
url,
r.status_code,
location_header,
)
location = _parts[1]
else:
location = r.json()["@odata.id"]
raise RedfishRequestError("No location from BMC: %s", r.text)

return (token, location)
else:
Expand Down
Loading