feat(ironic): ignore ports with the storage category from attachment #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have ports now for the regular network and the storage network but since Ironic has not shipped Trait Based Networking / Dynamic Networking yet we are not able to use logic to decide this. So add this hack until that feature lands and we can switch to it.
skrobul
approved these changes
Jan 13, 2026
Collaborator
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
+1 - is there any pending change request that we can log to this PR and lookup later? Or it has already been merged just not released?
Contributor
Author
|
This is part of the bigger dynamic networking and trait based networking spec. The field we're using will be for that but those features won't be available until 2026.1 so this is more of a stop gap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have ports now for the regular network and the storage network but since Ironic has not shipped Trait Based Networking / Dynamic Networking yet we are not able to use logic to decide this. So add this hack until that feature lands and we can switch to it.