Automated Resyntax fixes #700
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Keep imports in `require` sorted and grouped by phase, with collections before files.
The `define` form supports a shorthand for defining functions.
Use `make-temporary-directory` to make directories instead of `make-temporary-file`.
sorawee
reviewed
Jan 5, 2025
| expression | ||
| text))] | ||
| [text | ||
| (let-values ([(test-count test-passed-count |
Contributor
There was a problem hiding this comment.
This formats poorly :(
I'm surprised it's not converted to define-values though.
Collaborator
There was a problem hiding this comment.
There's 20 fixes in this pull request already, so it won't add more.
sorawee
reviewed
Jan 5, 2025
| check-failures | ||
| signature-violations) | ||
| (parse-test-failures text)]) | ||
| (when (not (equal? check-failures check-failures-expected)) |
Contributor
There was a problem hiding this comment.
Shouldn't this be unless? Ditto for below when
Collaborator
There was a problem hiding this comment.
Same comment as above about the fix limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 8 files.
let-to-definetidy-requiremake-temporary-directory-migrationdefine-lambda-to-define