Skip to content

Automated Resyntax fixes #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
resyntax-ci wants to merge 8 commits into from
Closed

Automated Resyntax fixes #714

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3cc93d1
Fix 1 occurrence of `cond-let-to-cond-define`
resyntax-ci[bot] Jan 19, 2025
b3be073
Fix 2 occurrences of `provide/contract-to-contract-out`
resyntax-ci[bot] Jan 19, 2025
2de1c08
Fix 10 occurrences of `let-to-define`
resyntax-ci[bot] Jan 19, 2025
042f6c4
Fix 2 occurrences of `if-else-false-to-and`
resyntax-ci[bot] Jan 19, 2025
ec35c55
Fix 1 occurrence of `cond-else-cond-to-cond`
resyntax-ci[bot] Jan 19, 2025
e970f8b
Fix 2 occurrences of `when-expression-in-for-loop-to-when-keyword`
resyntax-ci[bot] Jan 19, 2025
7eef6c1
Fix 1 occurrence of `send-chain-to-send+`
resyntax-ci[bot] Jan 19, 2025
24b6900
Fix 1 occurrence of `make-temporary-directory-migration`
resyntax-ci[bot] Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions drracket-test/tests/drracket/private/module-lang-test-utils.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,10 @@
(let loop ([snip (send interactions-text find-first-snip)])
(cond
[(not snip) '()]
[else
(cond
[(method-in-interface? 'get-stacks (object-interface snip))
(define-values (s1 s2) (send snip get-stacks))
(list* s1 s2 (loop (send snip next)))]
[else
(loop (send snip next))])])))))
[(method-in-interface? 'get-stacks (object-interface snip))
(define-values (s1 s2) (send snip get-stacks))
(list* s1 s2 (loop (send snip next)))]
[else (loop (send snip next))])))))
Copy link
Member

@rfindler rfindler Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not a good change. This is going against the data definition. That is, the outer cond is part of the processing of snip (there are two cases for the input and, in the second case of the input, I want to do a conditional thing).

(define output-passed?
(let ([r (test-result test)])
((cond [(string? r) string=?]
Expand Down