Automated Resyntax fixes #734
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
…parison` This comparison can be replaced with a simpler, more direct comparison.
This negated `when` expression can be replaced by an `unless` expression.
This method chain made of nested `send` expressions can be written more clearly as a `send+` expression.
This `if`-`else` chain can be converted to a `cond` expression.
rfindler
reviewed
Apr 13, 2025
| (<= 0 (- (send event get-y) y))) | ||
| (if (and (> (send event get-x) x) | ||
| (> (send event get-y) y)) | ||
| (when (not hit?) |
Member
There was a problem hiding this comment.
This doesn't look right. If we say (send event get-x) is b then we are doing something like this:
(<= 0 (- b x))
;; add x to both sides
(<= x b)
;; (attempt to) reverse the order of the comparison
(> b x)
but this isn't equivalent when b is equal to x
Collaborator
|
Closing since it produced a buggy change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 4 files.
let-to-definecomparison-of-difference-and-zero-to-direct-comparisonif-let-to-condsend-chain-to-send+nested-if-to-condinverted-when