Automated Resyntax fixes #746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This variable is returned immediately and can be inlined.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
`for` loops can build vectors directly.
This quasiquotation is equialent to a simple `list` call.
Member
|
I hadn't merged the previous one when this ran, so I'll just close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 4 files.
let-to-definemap-to-forif-let-to-condquasiquote-to-listlist->vector-to-for/vectorinline-unnecessary-definewhen-expression-in-for-loop-to-when-keywordalways-throwing-if-to-when