Automated Resyntax fixes #466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `else` clause of this `cond` expression is another `cond` expression and can be flattened.
Keep imports in `require` sorted and grouped by phase, with collections before files.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
This `begin` form can be flattened into the surrounding definition context.
This `define-syntax` macro can be replaced with a simpler, equivalent `define-syntax-rule` macro.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
sorawee
reviewed
Jan 8, 2025
| (raise exn)) | ||
| (void))]) | ||
| (define v (read log-file)) | ||
| (if (eof-object? v) |
Contributor
There was a problem hiding this comment.
Shouldn't this be converted to cond to allow further refactoring? Or does it hit the limit? @jackfirth
Contributor
There was a problem hiding this comment.
The let expression in the if body isn't refactorable, since it has a [v (deserialize v)] clause.
Member
|
Closing in favor of newer automated fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 10 files.
tidy-requirelet-to-definealways-throwing-if-to-whenif-let-to-condcond-else-cond-to-conddefine-syntax-syntax-rules-to-define-syntax-rulecond-let-to-cond-defineinline-unnecessary-beginwhen-expression-in-for-loop-to-when-keywordmap-to-for