Automated Resyntax fixes #469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep imports in `require` sorted and grouped by phase, with collections before files.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
…ellipses` This `->*` contract can be rewritten using `->` with ellipses.
This `map` operation can be replaced with a `for/list` loop.
This variable is returned immediately and can be inlined.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
This `begin` form can be flattened into the surrounding definition context.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
shhyou
reviewed
Jan 1, 2025
| empty | ||
| (cons/c rc rc)))) | ||
| rc) | ||
| (recursive-contract (or/c c empty (cons/c rc rc)))) |
Contributor
There was a problem hiding this comment.
@jackfirth this needs a side condition to make sure that rc doesn't occur in the body of define.
Contributor
There was a problem hiding this comment.
If the inlined definition binds a (non-recursive) lambda expression, would the name be lost?
Contributor
There was a problem hiding this comment.
Yes, but that doesn't happen because first those get rewritten into function definitions of the form (define (f) ...) (as opposed to (define f (lambda () ...))). Then, there's a check in the inlining rule to not inline function definitions, only variable definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 5 files.
provide/contract-to-contract-outwhen-expression-in-for-loop-to-when-keywordlet-to-definetidy-requireinline-unnecessary-defineinline-unnecessary-beginalways-throwing-if-to-whenmap-to-forarrow-contract-with-rest-to-arrow-contract-with-ellipses