Closed
Conversation
The `else` clause of this `cond` expression is another `cond` expression and can be flattened.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
This `map` operation can be replaced with a `for/list` loop.
…ellipses` This `->*` contract can be rewritten using `->` with ellipses.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This use of `string-append` can be removed by using `string-join`'s keyword arguments.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
sorawee
reviewed
Jan 8, 2025
| " | Package: " | ||
| (string-join (map ~a from-pkgs) ", ")) | ||
| "")))) | ||
| (string-join ", " |
Contributor
There was a problem hiding this comment.
@jackfirth I don't think this is correct. The first argument to string-join must be a list.
Contributor
|
Closing due to failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 7 files.
map-to-forprovide/contract-to-contract-outlet-to-definealways-throwing-if-to-whencond-else-cond-to-condor-hash-ref-set!-to-hash-ref!arrow-contract-with-rest-to-arrow-contract-with-ellipsesstring-append-and-string-join-to-string-join