Automated Resyntax fixes #483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This `map` operation can be replaced with a `for/list` loop.
This quasiquotation is equialent to a simple `list` call.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This use of `string-append` can be removed by using `string-join`'s keyword arguments.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
sorawee
reviewed
Feb 24, 2025
| id))) | ||
| (unless b | ||
| (error 'scribble "no class/interface/mixin information for identifier: ~e" id)) | ||
| (list (caddr b) (list-ref b 3) (list-ref b 4) (list-ref b 5) (list-ref b 6))) |
Contributor
There was a problem hiding this comment.
A combination of take and drop would be better IMO
Contributor
There was a problem hiding this comment.
Excellent idea. Added in jackfirth/resyntax#444.
Member
|
Conflicts with newer merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 9 files.
map-to-forprovide/contract-to-contract-outlet-to-definealways-throwing-if-to-whenif-let-to-condquasiquote-to-listunless-expression-in-for-loop-to-unless-keywordor-hash-ref-set!-to-hash-ref!string-append-and-string-join-to-string-joinfor/fold-result-keyword