Closed
Conversation
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `define` form supports a shorthand for defining functions.
sorawee
reviewed
Mar 26, 2025
| (let-values ([(x y) (ct-find main x)]) | ||
| y)) | ||
| subs))) | ||
| (define sorted-subs (sort subs (λ (x y) (< (left-edge-x main x) (left-edge-x main y))))) |
Contributor
There was a problem hiding this comment.
@jackfirth not sure if this is a good idea, but this could potentially be refactored to (sort subs < #:key (lambda (x) (left-edge-x main x)))
Contributor
There was a problem hiding this comment.
@sorawee That rule already exists, but it only fires in cases where no lambdas are needed. It doesn't seem clearer to me if you still need a lambda afterward.
Member
|
Conflicts with newer merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 1 file.
let-to-definedefine-lambda-to-define