Automated Resyntax fixes #499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
This `for-each` operation can be replaced with a `for` loop.
Using `cond` instead of `if` here makes `begin` unnecessary
This `define-syntax` macro can be replaced with a simpler, equivalent `define-syntax-rule` macro.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `or` expression can be turned into a clause of the inner `cond` expression, reducing nesting.
This negated `when` expression can be replaced by an `unless` expression.
jackfirth
reviewed
Apr 23, 2025
Comment on lines
-97
to
+100
| [title (or (attribute title) | ||
| (cond | ||
| [(= 1 (length (syntax->list #'(form ...)))) | ||
| #'example-title] | ||
| [else #'examples-title]))]) | ||
| [title (cond | ||
| [(attribute title) #t] | ||
| [(= 1 (length (syntax->list #'(form ...)))) #'example-title] | ||
| [else #'examples-title])]) |
Contributor
There was a problem hiding this comment.
This change is buggy. If (attribute title) returns a non-#f and non-#t value, this change coerces it to #t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 8 files.
map-to-forlet-to-defineread-line-anyunless-expression-in-for-loop-to-unless-keywordcond-let-to-cond-definefor-each-to-forif-let-to-conddefine-syntax-syntax-rules-to-define-syntax-ruleif-begin-to-condor-cond-to-condinverted-when