Automated Resyntax fixes

[resyntax-ci]

This is an automated change generated by Resyntax.

Pass 1

Applied 3 fixes to typed-racket-lib/typed-racket/base-env/annotate-classes.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
• Line 172, if-else-false-to-and: This if expression can be refactored to an equivalent expression using and.
• Line 331, define-values-values-to-define: This use of define-values is unnecessary.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/ann-inst.rkt

• Line 8, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-test/optimizer/reset-port.rkt

• Line 8, read-line-any: Specify a line mode of 'any with read-line to avoid differences between Windows and other platforms.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/base-env-indexing-abs.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 3 fixes to typed-racket-test/optimizer/transform.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
• Line 24, read-line-any: Specify a line mode of 'any with read-line to avoid differences between Windows and other platforms.
• Line 35, if-begin-to-cond: Using cond instead of if here makes begin unnecessary

Applied 1 fix to typed-racket-lib/typed-racket/base-env/prims-lambda.rkt

• Line 9, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/base-env-indexing.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/unit-prims.rkt

• Line 136, map-to-for: This map operation can be replaced with a for/list loop.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/base-structs.rkt

• Line 14, provide-deduplication: Providing the same identifier multiple times is unnecessary.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/class-prims.rkt

• Line 5, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-test/optimizer/known-bugs.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 2 fixes to typed-racket-lib/typed-racket/base-env/base-contracted.rkt

• Line 6, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
• Line 34, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/class-clauses.rkt

• Line 8, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/optimizer/sequence.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/extra-env-lang.rkt

• Line 9, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/for-clauses.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/base-special-env.rkt

• Line 5, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/env-lang.rkt

• Line 5, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 1 fix to typed-racket-lib/typed-racket/base-env/base-types-extra.rkt

• Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Applied 2 fixes to typed-racket-test/optimizer/run.rkt

• Line 2, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
• Line 14, read-line-any: Specify a line mode of 'any with read-line to avoid differences between Windows and other platforms.

Summary

Fixed 26 issues in 20 files.

• Fixed 18 occurrences of tidy-require
• Fixed 3 occurrences of read-line-any
• Fixed 1 occurrence of if-begin-to-cond
• Fixed 1 occurrence of if-else-false-to-and
• Fixed 1 occurrence of define-values-values-to-define
• Fixed 1 occurrence of map-to-for
• Fixed 1 occurrence of provide-deduplication

[samth]

It would be helpful in the future to group changes by rule (either into separate commits in a PR, separate PRs, separate parts of the PR description, etc).

[jackfirth]

That's possible but very tricky because multiple passes are made in a single pull request. So it might be the case that it's not possible to split up the changes into individual commits by rule type.

[sorawee]

I know 'any is preferable in general, but does it break anything here?

[sorawee]

Oh, it's just for testing. Probably doesn't matter.

[jackfirth]

Resyntax rules strive to preserve intended behavior, rather than actual behavior. So unless the original author of this code intended it to behave differently across platforms, I'm fine with relying on the CI signal to determine if this change is appropriate. And if that was intentional, I'm of the opinion that writing out (read-line port 'linefeed) explicitly and including a comment is a better way to do that.

[jackfirth]

Closing this one in favor of newer pull requests which split the changes into multiple commits.