Skip to content

Fix correspondence between location/c and Location in typed/racket #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Fix correspondence between location/c and Location in typed/racket #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d01ea97
fix correspondence between location? and Location in typed/racket
joergen7 Nov 26, 2024
858d6d4
maintain Location as struct type
joergen7 Nov 26, 2024
6e4e61b
Merge remote-tracking branch 'upstream/master'
joergen7 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions typed-racket-more/typed/xml.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
[offset : Exact-Nonnegative-Integer])
#:type-name Location]
[#:struct source
([start : Location]
[stop : Location])
([start : (U Location Symbol False)]
[stop : (U Location Symbol False)])
#:type-name Source]
[#:struct external-dtd
([system : String])
Expand Down
25 changes: 25 additions & 0 deletions typed-racket-test/unit-tests/xml-tests.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#lang typed/racket/base

(module+ test

(require typed/rackunit
"../../typed-racket-more/typed/xml.rkt")

(let ([xml-p-i
(p-i #f #f 'xml "version=\"1.0\" encoding=\"UTF-8\"")])
(check-eq?
(source-start xml-p-i)
#f)
(check-eq?
(source-stop xml-p-i)
#f))

(let ([xml-p-i
(p-i 'racket 'racket 'xml "version=\"1.0\" encoding=\"UTF-8\"")])
(check-eq?
(source-start xml-p-i)
'racket)
(check-eq?
(source-stop xml-p-i)
'racket)))

Loading