Automated Resyntax fixes #1416
Closed
Automated Resyntax fixes #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if` expression can be refactored to an equivalent expression using `and`.
This `match` expression can be simplified using `match-define`.
Keep imports in `require` sorted and grouped by phase, with collections before files.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
This expression is equivalent to calling the `positive?` predicate.
The `define` form supports a shorthand for defining functions.
This `let-values` expression can be replaced with a simpler, equivalent `call-with-values` expression.
This negated `unless` expression can be replaced by a `when` expression.
Using `cond` instead of `if` here makes `begin` unnecessary
The `let` expression in this `begin0` form can be extracted into the surrounding definition context.
This `case-lambda` form only has one case. Use a regular lambda instead.
This `sort` expression can be replaced with a simpler, equivalent expression.
This negated `when` expression can be replaced by an `unless` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 44 issues in 20 files.
tidy-requiresingle-clause-match-to-match-definelet-to-definelet-values-then-call-to-call-with-valuesdefine-simple-macro-to-define-syntax-parse-rulesort-with-keyed-comparator-to-sort-by-keyzero-comparison-to-positive?case-lambda-with-single-case-to-lambdaif-begin-to-condinverted-whendefine-lambda-to-definecond-let-to-cond-defineinverted-unlessbegin0-let-to-define-begin0if-else-false-to-and