Automated Resyntax fixes #1435
Closed
Automated Resyntax fixes #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
This negated `when` expression can be replaced by an `unless` expression.
This `if` expression can be refactored to an equivalent expression using `and`.
The `syntax-disarm` function is a legacy function that does nothing.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `define` form supports a shorthand for defining functions.
Using `cond` instead of `if` here makes `begin` unnecessary
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
The `null?` predicate can be used to test for the empty list.
This conditional expression can be replaced with a simpler, equivalent expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `case-lambda` form only has one case. Use a regular lambda instead.
This expression is equivalent to calling the `positive?` predicate.
This `match` expression can be simplified using `match-define`.
This use of `define-values` is unnecessary.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This quasiquotation is equialent to a simple `list` call.
This `begin` form can be flattened into the surrounding definition context.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if`-`else` chain can be converted to a `cond` expression.
This `match` expression can be simplified using `match-define`.
This `let` expression can be pulled up into a `define` expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 49 issues in 20 files.
let-to-definecond-let-to-cond-definezero-comparison-to-positive?read-line-anydefine-lambda-to-definedefine-values-values-to-definesingle-clause-match-to-match-defineif-begin-to-condnested-if-to-condinverted-whendefine-simple-macro-to-define-syntax-parse-ruleif-x-else-x-to-andif-else-false-to-andinline-unnecessary-beginwhen-expression-in-for-loop-to-when-keywordcase-lambda-with-single-case-to-lambdaquasiquote-to-listfor/fold-result-keyworddefine-let-to-double-defineequal-null-list-to-null-predicatealways-throwing-if-to-whenunless-expression-in-for-loop-to-unless-keywordsyntax-disarm-migration