Support possibility to run gateway and frontend in HTTP server subfolder #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
force-pushed
the
pr/feat-388
branch
3 times, most recently
from
0de065d to
52048e9
Compare
Add possibility to define frontend application base path (prefix of all routes) with VITE_BASE_PATH environment variable. By default, it stays / in development mode. In production mode (w/ npm run build), the default is /__SLURMWEB_BASE__ placeholder designed to be replaced at gateway runtime.
Replace at runtime base path placeholder in pre-built UI assets by URL path extracted from configured UI public host to support running under under a subfolder prefix on HTTP server The UI prebuilt assets are first copied the source frontend UI assets to a target directory, the placeholder base paths are then replaced in the UI assets files in the target directory. The target directory is created in the system's systemd runtime directory, typically /run/slurm-web-gateway/ui, or in a temporary directory if the RUNTIME_DIRECTORY environment variable is not set. The placeholder base path, set at frontend application build time, is replaced with the path configured in the public URL prefix. This makes the same build usable under any path without rebuilding the frontend application. This approach is not great, to say the least, but considering the limits of the frontend application build process, it's the best we have found so far. fix #388
Wrap all gateway endpoints under the configured UI public URL path prefix when defined. By default, the path prefix is empty and the endpoints are at root path of HTTP server.
Update documentation of [ui]>host gateway parameter to explain its role in frontend application.
Add catch-all route to report page not found with button to clusters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending tasks:
fix #388