-
Notifications
You must be signed in to change notification settings - Fork 121
feat(dev): add Dockerfile for container deployment #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Multi-stage build for gateway and agent components - Includes frontend built from source - GTK/Pango dependencies for RacksDB visualization - LDAP dependencies for authentication support - docker-compose.yml for local development Tested on: - Docker Desktop (macOS) - AWS EKS (Kubernetes 1.34) - Slurm 25.11.0 via Slinky operator
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hello @gaujain-nv, First, thank you very much for this contribution, this is really appreciated. For the sake of clarity, do you work with @faganihajizada? He mentioned such contribution in #683 (comment).
TBH, I'm not familiar with Docker and containers best practices. Is this the standard way to instantiate an application with different arguments in Docker world?
Can you elaborate on why it would be messy to install Slurm-web packages in container images? I see several advantages with this packages approach:
Yes please! I think it is expected by users.
Yes please, at least docs/modules/install/pages/install/containers/docker.adoc must be updated to explain how to start Slurm-web with
Of course!
I think Debian stable is a good choice, well maintained by a great community.
Yes indeed, that's my intent. |
@rezib we are going to meet and discuss this internally and we will get back to you on this. Thank you! |
Heh I guess the perspective has changed a bit considering the recent announcement 😅 |
|
Hi @rezib **Re: @faganihajizada ** - Yes! Fagani and I work together at NVIDIA. He raised the idea in #683, and I'm implementing it. We're coordinating on this effort. Re: Re: Debian packages - You're absolutely right, and I apologize for the "messy" wording. I wasn't aware your packages were available for container use. Using your Debian packages is clearly the better approach:
I'll update the Dockerfile to use Question: Could you share the exact repository URL and package name(s)? I tried: |
Well, I really don't know what's the best pattern for Slurm-web… so follow your own intuition for now!
Debian stable is trixie these days, bookworm is the oldstable with less maintenance workforce. Debian project publishes the
You can refer to: https://docs.rackslab.io/slurm-web/install/install/distribs/debian.html It gives the URL of the keyring, the repository and package names. |
Summary
This PR adds Docker container support for Slurm-web, enabling deployment via containers and Kubernetes.
Changes
Dockerfilewith multi-stage build:docker-compose.ymlfor local developmentUsage
Testing
Tested on:
Motivation
Currently Slurm-web is distributed via deb/rpm packages. Container support enables:
Checklist