Fix tests failures with nodejs 20 and 24 #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the stray console.log in the empty breadcrumb test so output stays clean. This keeps test runs quiet while preserving the same assertions.
Replace RESTAPI multipart fixtures with a GatewayAPI mock and Canvas stubs so the component spec focuses on UI state updates. This avoids undici multipart parsing differences between Node 20/24 that previously caused unhandled rejections and masked UI failures. Move multipart expectations into GatewayAPI.spec by stubbing Response.formData() with a minimal FormData-like object. This keeps the parsing logic covered while eliminating undici's File/Blob validation path in the component tests. Also import Node's File/Blob and assign them to globalThis for the test runtime. This avoids undici Web IDL assertion failures when jsdom File/Blob are used. fix #651
Mount the component before setting returnUrl and wait a tick for updates. This prevents inject() warnings and keeps the alert assertion stable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #651