Collect dependency data from import declarations #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15. This checks for import declarations as well as require statements, which paves the way for components to be authored using ES6 syntax.
It doesn't rewrite anything (unlike #20) because the loader might need to rewrite
requirestatements asimportdeclarations or vice versa – so at the moment it's not particularly useful. Not sure how best to handle it – could possible addimportsandrequiresarrays, or something like that (with objects withstart,end,content,sourceproperties?type,name, etc?), or should that be the job of loaders? Maybe we addrcu.convertRequiresToImportsandrcu.convertImportsToRequiresor something. (This probably involves some hand-waving around ES6 module semantics.)