Refactor Snake and Snake2 into one common l0dable #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a complaint that it was hard to kill yourself during a certain talk...
Closed
j0ju
pushed a commit
to j0ju/f1rmware
that referenced
this pull request
Nov 8, 2016
Conflicts: l0dables/Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already a few times some fixes came for Snake1 and didn't for Snake2 or vice versa. Those two games differ by basically just two ifs, so let's unify their codebases (and backport/fix some of the remaining issues).
Note: This PR deprecates PR #136, as it already includes its improvements.