Skip to content

wipAxff #24912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wipAxff #24912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df20eea
Aim to fix the axff bug
radare Nov 23, 2025
27541aa
add test
radare Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions libr/anal/xrefs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,19 +175,18 @@ static RVecAnalRef *_collect_all_refs(RefManager *rm, const AdjacencyList *adj_l

static RVecAnalRef *_collect_refs_from(const AdjacencyList *adj_list, ut64 from) {
// only finds entries with matching "from"
RVecAnalRef *result = RVecAnalRef_new ();
if (R_UNLIKELY (!result)) {
return NULL;
}

const Edges *edges = NULL;
{
AdjacencyList_CIter iter = AdjacencyList_cfind (adj_list, &from);
const AdjacencyList_Entry *entry = AdjacencyList_CIter_get (&iter);
edges = entry ? entry->val : NULL;
}
if (!edges) {
RVecAnalRef_free (result);
return NULL;
}

RVecAnalRef *result = RVecAnalRef_new ();
if (R_UNLIKELY (!result)) {
return NULL;
}

Expand Down Expand Up @@ -527,10 +526,10 @@ static RVecAnalRef *fcn_get_all_refs(RAnalFunction *fcn, RefManager *rm, Collect
RListIter *iter;
RAnalBlock *bb;
r_list_foreach (fcn->bbs, iter, bb) {
int i;
for (i = 0; i < bb->ninstr; i++) {
ut64 instr_addr = bb->addr + r_anal_bb_offset_inst (bb, i);
RVecAnalRef *refs = collect_refs (rm, instr_addr);
ut64 addr;
ut64 end = bb->addr + bb->size;
for (addr = bb->addr; addr < end; addr++) {
RVecAnalRef *refs = collect_refs (rm, addr);
if (!refs) {
continue;
}
Expand Down
61 changes: 61 additions & 0 deletions test/db/anal/xrefs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,64 @@ EXPECT=<<EOF
0x10000049c 00021fd6 br x16
EOF
RUN

NAME=axff missing mipsrefs
FILE=bins/elf/mips-ncc
CMDS=<<EOF
aae @ sym.doEventInternal ;axl~sym.readInfo_log~sym.doEventInternal~CALL
EOF
EXPECT=<<EOF
sym.doEventInternal+140 0x4978bc > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+240 0x497920 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+456 0x4979f8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+604 0x497a8c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+3228 0x4984cc > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+3260 0x4984ec > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+3484 0x4985cc > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+3516 0x4985ec > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+3552 0x498610 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+3604 0x498644 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+4944 0x498b80 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+5000 0x498bb8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+5388 0x498d3c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+5420 0x498d5c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+5456 0x498d80 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+5508 0x498db4 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+5984 0x498f90 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+6040 0x498fc8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+6404 0x499134 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+7016 0x499398 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+7880 0x4996f8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+7912 0x499718 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+8856 0x499ac8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+8888 0x499ae8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+9832 0x499e98 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+9864 0x499eb8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+10132 0x499fc4 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+10176 0x499ff0 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+10208 0x49a010 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+11196 0x49a3ec > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+11676 0x49a5cc > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+12320 0x49a850 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+14164 0x49af84 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16368 0x49b820 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16568 0x49b8e8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16652 0x49b93c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16684 0x49b95c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16716 0x49b97c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16744 0x49b998 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+16776 0x49b9b8 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+17860 0x49bdf4 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18064 0x49bec0 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18152 0x49bf18 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18208 0x49bf50 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18244 0x49bf74 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18288 0x49bfa0 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18324 0x49bfc4 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18432 0x49c030 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+18908 0x49c20c > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+20808 0x49c978 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+23360 0x49d370 > CALL:--x > 0x523760 sym.readInfo_log
sym.doEventInternal+23484 0x49d3ec > CALL:--x > 0x523760 sym.readInfo_log
EOF
RUN
Loading