Skip to content

Minor type propagation fixes#25137

Open
trufae wants to merge 4 commits intomasterfrom
typo
Open

Minor type propagation fixes#25137
trufae wants to merge 4 commits intomasterfrom
typo

Conversation

@trufae
Copy link
Collaborator

@trufae trufae commented Dec 24, 2025

  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some lines in the book (optional)

Description

Copilot AI review requested due to automatic review settings December 24, 2025 16:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix several type propagation issues in the radare2 codebase, including proper struct initialization, state reset enhancements, memory cleanup, and null pointer checks.

  • Initialize RAnalOp structure to prevent undefined behavior
  • Enhance state reset functionality to clear additional fields
  • Add memory cleanup between basic block iterations
  • Improve null pointer safety checks for operation type access

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
libr/core/casm.c Initializes RAnalOp structure to zero to prevent use of uninitialized data
libr/anal/p/anal_tp.c Adds state reset for prev_var/userfnc/prev_type fields, memory cleanup for ret_type/ret_reg between basic blocks, and additional null check for next_op type field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

trufae and others added 3 commits December 24, 2025 17:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants